Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1388: Deprecate source-git-tag #1801

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Sep 18, 2024

Motivation

Fixes #1787
Fixes CLI-1388

Proposed changes

Deprecate --source-git-tag. If --destination-git-branch is set, use it for the same purpose.

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1801/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1801/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (93dcab1) to head (4bb29e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1801   +/-   ##
=========================================
  Coverage     92.23%   92.23%           
- Complexity     1817     1818    +1     
=========================================
  Files           121      121           
  Lines          6823     6825    +2     
=========================================
+ Hits           6293     6295    +2     
  Misses          530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell added the bug Something isn't working label Sep 19, 2024
@danepowell danepowell marked this pull request as ready for review September 19, 2024 16:13
@danepowell danepowell merged commit 1139728 into acquia:main Sep 19, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-1388: Error on push:artifacts when source and destination tag values are the same.
1 participant